276 Commits

Author	SHA1	Message	Date
Daniel Barber	47c273c7ad	Add missing edit menu	2020-03-07 13:10:41 -05:00
Daniel Barber	98e741d9fe	✂️	2020-03-06 12:01:57 -05:00
Daniel Barber	6ccaef91a1	Add more informative messages	2020-03-06 11:36:04 -05:00
Daniel Barber	c4e5f7408a	Handle connection/disconnection better ... * Add menu options to connect/disconnect * Add option to attempt reconnection on fatal error * Add ability to reset connection to MPDClient	2020-03-03 11:11:10 -05:00
Daniel Barber	b46cbf229f	Refactor error and retain server connected state	2020-03-03 11:11:10 -05:00
Daniel Barber	063b8da202	Handle errors connecting to MPD	2020-03-03 11:11:09 -05:00
Daniel Barber	7fac6cd38e	Use grid view to layout preference views	2020-02-28 11:08:27 -05:00
Daniel Barber	1077475552	Fix bug adding albums to queue	2020-02-24 08:25:21 -05:00
Daniel Barber	91c82bbc6f	Add volume control	2020-02-19 18:08:22 -05:00
Daniel Barber	123f9c1e4a	Tweak priorities of commands	2020-02-16 14:39:12 -05:00
Daniel Barber	cd2e5efc95	Cache the small image when we get the browser art ... We use the RawImageDataProvider here to pass the already downloaded image onto this transform, to avoid fetching it from MPD again. The 180x180 size artwork is plenty big enough to use as source for the 32x32 queue/dragged song artwork.	2020-02-16 12:51:11 -05:00
Daniel Barber	a663315013	💄	2020-02-16 12:50:56 -05:00
Daniel Barber	6236884195	Fix a nasty deadlock	2020-02-16 12:50:32 -05:00
Daniel Barber	f22b5b022c	We were chasing a red herring ... It should actually be perfectly ok to send `noidle` before the call to `recv_idle`. It just means the `recv_idle` will return immediately.	2020-02-15 21:36:41 -05:00
Daniel Barber	cacb0b0124	Trying to lock when we already have the lock is bad	2020-02-15 21:36:41 -05:00
Daniel Barber	f39c2a4f99	Remove redundant selfs	2020-02-15 21:36:41 -05:00
Daniel Barber	abe2c293eb	This does not need to be async on the main thread ... In fact doing so causes us to idle excessively.	2020-02-15 21:36:40 -05:00
Daniel Barber	abf1579789	Hold onto idleLock while we handle idle	2020-02-15 21:36:40 -05:00
Daniel Barber	2f59eaeecf	Woops, we were reading this outside of the lock!	2020-02-15 21:36:40 -05:00
Daniel Barber	fa338ee790	Address some PR feedback	2020-02-15 21:36:40 -05:00
Daniel Barber	a7e7620f68	Attempt to fix album detail view crash ... Very occasionally the album detail view fails to get the album tracks and this causes a crash. This extra guard avoids the crash, but doesn't fix the underlying problem. The problem itself is very hard to track down because it's incredibly hard to reproduce.	2020-02-15 21:36:39 -05:00
Daniel Barber	eb5cee2a75	Fix potential race	2020-02-15 21:36:39 -05:00
Daniel Barber	f39f69b4dc	We can just reuse the same provider	2020-02-15 21:36:39 -05:00
Daniel Barber	7c99a9a712	We never mutate this	2020-02-15 21:36:39 -05:00
Daniel Barber	7f8e209970	Self *could* get deallocated here	2020-02-15 21:36:38 -05:00
Daniel Barber	c0f8badbb5	Fix deprecation warning	2020-02-15 21:36:38 -05:00
Daniel Barber	3b4b5f5b5c	Refactor cover art refresh using Promises	2020-02-15 21:36:38 -05:00
Daniel Barber	ff3c7c4856	Fetching album art via MPD connection now ... - Remove music dir prefs + Add refresh album art option to album list context menu + Wire up album view context menu + Force an idle after transport commands + Add "clear cache" button	2020-02-15 21:36:38 -05:00
Daniel Barber	59d09f70fe	Fix bug showing duplicate albums ... Albums with tracks tagged with different years were showing one instance of the album for each year present in the tracks. This should fix that.	2020-02-13 10:35:15 -05:00
Daniel Barber	e31f46d1a6	Update copyright year	2020-01-31 13:53:38 -05:00
Daniel Barber	72379a1bad	Wire up album browser context menu	2020-01-31 13:52:17 -05:00
Daniel Barber	1f61a7d4c7	Stick with white queue icons	2020-01-29 21:48:44 -05:00
Daniel Barber	d37c908d4f	We need to reset these when the cell is prepared for reuse	2020-01-29 21:07:17 -05:00
Daniel Barber	d38cc040b6	Fix occasional launch crash bug	2020-01-29 21:06:03 -05:00
Daniel Barber	faa60733b7	Set current playing cover art background to black ... This makes non square cover art look better.	2020-01-28 08:55:07 -05:00
Daniel Barber	0cca68fae5	Fix fonts	2020-01-28 08:54:59 -05:00
Daniel Barber	043659ff1c	🔪	2020-01-26 21:19:23 -05:00
Daniel Barber	bbeabb34fc	Use and imageView instead of a button for the queue icon	2020-01-26 21:16:01 -05:00
Daniel Barber	9bbf6fb875	Handle albums with a zero disc	2020-01-22 22:34:45 -05:00
Daniel Barber	a8987029f5	Redesign queue view ... * Add cover art for each track * Stack song title and artist * Add song duration * Redesign the dragged image view to match	2020-01-22 22:23:59 -05:00
Daniel Barber	ae075914b3	Use NSString helper here	2020-01-20 13:36:08 -05:00
Daniel Barber	27425b76d6	No need for parentheses here	2020-01-20 13:36:06 -05:00
Daniel Barber	2932ab9e33	Eliminate some single line functions	2020-01-20 13:36:04 -05:00
Daniel Barber	f878daad2c	Create constants for sizes	2020-01-20 13:36:03 -05:00
Daniel Barber	555a99d5be	We don't need self here	2020-01-20 13:36:03 -05:00
Daniel Barber	b8698d2830	✂️ stray space ... Co-Authored-By: louis-antonopoulos <louis@thoughtbot.com>	2020-01-20 13:36:02 -05:00
Daniel Barber	8f3e93db66	✂️	2020-01-20 13:36:02 -05:00
Daniel Barber	3405df578b	Something something storyboard editor	2020-01-20 13:36:02 -05:00
Daniel Barber	0e996cbb4c	We can simplify this	2020-01-20 13:36:01 -05:00
Daniel Barber	26646ea88e	We don't need this at the moment	2020-01-20 13:36:01 -05:00