From 0147ffbfdaf080579234d2b1501aba9ce3348666 Mon Sep 17 00:00:00 2001 From: Dan Barber Date: Sat, 23 Mar 2019 14:29:41 -0400 Subject: [PATCH] Couple of tweaks --- Persephone/Services/AlbumArtService.swift | 21 ------------------- .../Extensions/AlbumArtService+Remote.swift | 5 ++--- bin/release | 10 +++++++++ 3 files changed, 12 insertions(+), 24 deletions(-) create mode 100755 bin/release diff --git a/Persephone/Services/AlbumArtService.swift b/Persephone/Services/AlbumArtService.swift index 564413d..510c19b 100644 --- a/Persephone/Services/AlbumArtService.swift +++ b/Persephone/Services/AlbumArtService.swift @@ -52,24 +52,3 @@ class AlbumArtService { } } } - - -//getCachedArtwork -// .then { -// callback($0) -// } -// .catch { -// getFileSystemArtwork -// } -// .then { -// callback($0) -// } -// .catch { -// getRemoteArtwork -// }4 -// .then { -// callback($0) -// } -// -//// [() -> Promise] -//// () -> Promise diff --git a/Persephone/Services/Extensions/AlbumArtService+Remote.swift b/Persephone/Services/Extensions/AlbumArtService+Remote.swift index 5829370..21cbb84 100644 --- a/Persephone/Services/Extensions/AlbumArtService+Remote.swift +++ b/Persephone/Services/Extensions/AlbumArtService+Remote.swift @@ -36,9 +36,8 @@ extension AlbumArtService { }.compactMap { $0["releases"][0]["id"].string }.compactMap { - URLComponents(string: "https://coverartarchive.org/release/\($0)/front-500") - }.then { (urlComponents: URLComponents?) -> Promise<(data: Data, response: URLResponse)> in - let url = urlComponents!.url + URLComponents(string: "https://coverartarchive.org/release/\($0)/front-500")?.url + }.then { (url: URL?) -> Promise<(data: Data, response: URLResponse)> in return URLSession.shared.dataTask(.promise, with: url!).validate() }.compactMap { NSImage(data: $0.data)?.toFitBox( diff --git a/bin/release b/bin/release new file mode 100755 index 0000000..83c01ed --- /dev/null +++ b/bin/release @@ -0,0 +1,10 @@ +#!/bin/sh + +set -o pipefail && \ + +xcodebuild \ + -project Persephone.xcodeproj \ + -scheme Persephone \ + -destination platform\=macOS build \ + -configuration Release \ +| xcpretty