Add shoulda matchers and some specs

Gemfile

@@ -24,9 +24,10 @@ group :development, :test do
   gem "better_errors"
   gem "binding_of_caller"
   gem "pry"
-  gem "rspec-rails"
 end
 
 group :test do
   gem "capybara"
+  gem "rspec-rails"
+  gem "shoulda-matchers"
 end

Gemfile.lock

@@ -199,6 +199,12 @@ GEM
       tilt (>= 1.1, < 3)
     sdoc (1.0.0)
       rdoc (>= 5.0)
+    shoulda (3.6.0)
+      shoulda-context (~> 1.0, >= 1.0.1)
+      shoulda-matchers (~> 3.0)
+    shoulda-context (1.2.2)
+    shoulda-matchers (3.1.2)
+      activesupport (>= 4.0.0)
     simple_form (4.0.1)
       actionpack (>= 5.0)
       activemodel (>= 5.0)
@@ -244,6 +250,8 @@ DEPENDENCIES
   rspec-rails
   sass-rails
   sdoc
+  shoulda
+  shoulda-matchers
   simple_form
   uglifier
 

app/models/user.rb

@@ -8,10 +8,12 @@ class User < ActiveRecord::Base
   end
 
   def self.create_from_auth(auth)
-    create(provider: auth.provider,
+    create(
-           uid: auth.uid,
+      provider: auth.provider,
-           username: auth.info.nickname,
+      uid: auth.uid,
-           name: auth.info.name,
+      username: auth.info.nickname,
-           avatar_url: auth.info.image)
+      name: auth.info.name,
+      avatar_url: auth.info.image,
+    )
   end
 end

spec/controllers/home_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "rails_helper"
 
 describe HomeController do
 

spec/controllers/images_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "rails_helper"
 
 describe ImagesController do
 

spec/controllers/sessions_controller_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "rails_helper"
 
 describe SessionsController do
 

spec/helpers/home_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "rails_helper"
 
 # Specs in this file have access to a helper object that includes
 # the HomeHelper. For example:

spec/helpers/images_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "rails_helper"
 
 # Specs in this file have access to a helper object that includes
 # the ImagesHelper. For example:

spec/helpers/sessions_helper_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "rails_helper"
 
 # Specs in this file have access to a helper object that includes
 # the SessionsHelper. For example:

spec/models/image_spec.rb

@@ -1,7 +1,10 @@
-require 'spec_helper'
+require "rails_helper"
 
 describe Image do
-  it 'should not be valid without an image' do
+  it { is_expected.to validate_presence_of(:image) }
+  it { is_expected.to belong_to(:user) }
+
+  it "should not be valid without an image" do
     image = Image.new
     expect(image).not_to be_valid
   end

spec/models/user_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
+require "rails_helper"
 
 describe User do
-  pending "add some examples to (or delete) #{__FILE__}"
+  it { is_expected.to have_many(:images) }
 end

spec/rails_helper.rb

@@ -0,0 +1,70 @@
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+require "spec_helper"
+ENV["RAILS_ENV"] ||= "test"
+require File.expand_path("../config/environment", __dir__)
+# Prevent database truncation if the environment is production
+if Rails.env.production?
+  abort("The Rails environment is running in production mode!")
+end
+require "rspec/rails"
+# Add additional requires below this line. Rails is not loaded until this point!
+
+# Requires supporting ruby files with custom matchers and macros, etc, in
+# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+# run as spec files by default. This means that files in spec/support that end
+# in _spec.rb will both be required and run as specs, causing the specs to be
+# run twice. It is recommended that you do not name files matching this glob to
+# end with _spec.rb. You can configure this pattern with the --pattern
+# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
+#
+# The following line is provided for convenience purposes. It has the downside
+# of increasing the boot-up time by auto-requiring all files in the support
+# directory. Alternatively, in the individual `*_spec.rb` files, manually
+# require only the support files necessary.
+#
+# Dir[Rails.root.join('spec', 'support', '**', '*.rb')].each { |f| require f }
+
+# Checks for pending migrations and applies them before tests are run.
+# If you are not using ActiveRecord, you can remove these lines.
+begin
+  ActiveRecord::Migration.maintain_test_schema!
+rescue ActiveRecord::PendingMigrationError => e
+  puts e.to_s.strip
+  exit 1
+end
+RSpec.configure do |config|
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = true
+
+  # RSpec Rails can automatically mix in different behaviours to your tests
+  # based on their file location, for example enabling you to call `get` and
+  # `post` in specs under `spec/controllers`.
+  #
+  # You can disable this behaviour by removing the line below, and instead
+  # explicitly tag your specs with their type, e.g.:
+  #
+  #     RSpec.describe UsersController, :type => :controller do
+  #       # ...
+  #     end
+  #
+  # The different available types are documented in the features, such as in
+  # https://relishapp.com/rspec/rspec-rails/docs
+  config.infer_spec_type_from_file_location!
+
+  # Filter lines from Rails gems in backtraces.
+  config.filter_rails_from_backtrace!
+  # arbitrary gems may also be filtered via:
+  # config.filter_gems_from_backtrace("gem name")
+end
+
+Shoulda::Matchers.configure do |config|
+  config.integrate do |with|
+    with.test_framework :rspec
+    with.library :rails
+  end
+end

spec/spec_helper.rb

@@ -1,42 +1,96 @@
-# This file is copied to spec/ when you run 'rails generate rspec:install'
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all
-ENV["RAILS_ENV"] ||= 'test'
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-require File.expand_path("../../config/environment", __FILE__)
+# The generated `.rspec` file contains `--require spec_helper` which will cause
-require 'rspec/rails'
+# this file to always be loaded, without a need to explicitly require it in any
-require 'rspec/autorun'
+# files.
-
+#
-# Requires supporting ruby files with custom matchers and macros, etc,
+# Given that it is always loaded, you are encouraged to keep this file as
-# in spec/support/ and its subdirectories.
+# light-weight as possible. Requiring heavyweight dependencies from this file
-Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f }
+# will add to the boot time of your test suite on EVERY test run, even for an
-
+# individual file that may not need all of that loaded. Instead, consider making
-# Checks for pending migrations before tests are run.
+# a separate helper file that requires the additional dependencies and performs
-# If you are not using ActiveRecord, you can remove this line.
+# the additional setup, and require it from the spec files that actually need
-ActiveRecord::Migration.check_pending! if defined?(ActiveRecord::Migration)
+# it.
-
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  # ## Mock Framework
+  # rspec-expectations config goes here. You can use an alternate
-  #
+  # assertion/expectation library such as wrong or the stdlib/minitest
-  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
+  # assertions if you prefer.
-  #
+  config.expect_with :rspec do |expectations|
-  # config.mock_with :mocha
+    # This option will default to `true` in RSpec 4. It makes the `description`
-  # config.mock_with :flexmock
+    # and `failure_message` of custom matchers include text for helper methods
-  # config.mock_with :rr
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
 
-  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  # rspec-mocks config goes here. You can use an alternate test double
-  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
 
-  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
-  # examples within a transaction, remove the following line or assign false
+  # have no way to turn it off -- the option exists only for backwards
-  # instead of true.
+  # compatibility in RSpec 3). It causes shared context metadata to be
-  config.use_transactional_fixtures = true
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
 
-  # If true, the base class of anonymous controllers will be inferred
+# The settings below are suggested to provide a good initial experience
-  # automatically. This will be the default behavior in future versions of
+# with RSpec, but feel free to customize to your heart's content.
-  # rspec-rails.
+=begin
-  config.infer_base_class_for_anonymous_controllers = false
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = "doc"
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = "random"
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
 end